Is it just me
-
or does looking at really stupid code make you feel sick to your stomach, too? X|
:josh: My WPF Blog[^]
-
or does looking at really stupid code make you feel sick to your stomach, too? X|
:josh: My WPF Blog[^]
There is a place for this you know! And not to ding you for posting code or anything but here![^] We did a brownbag here on refactoring code. They asked for samples so one of the folks brought in a sample from a section of code that was very hard to work with.
class User { string first; string middle; string last; object oMisc; ... several hundred oddly named methods. object getMisc(){...} setMisc(object o){...} ... several hundred other oddly named methods. }This was java and nobody had a clue what the misc object was. They guy who wrote it was now his boss. Obviously the guy who brought in the code is now working elsewhere.ed ~"Watch your thoughts; they become your words. Watch your words they become your actions. Watch your actions; they become your habits. Watch your habits; they become your character. Watch your character; it becomes your destiny." -Frank Outlaw.
-
Christopher Duncan wrote:
atoi()
How do other people pronounce that? Right or wrong, I've gotten used to saying something along the lines of "a-toy" rather than "a-to-i" over the years. I must admit I've gotten some odd looks before. :laugh:
Jeremy Falcon
ah-too-eee
Silence is the voice of complicity. Strange women lying in ponds distributing swords is no basis for a system of government. -- monty python Might I suggest that the universe was always the size of the cosmos. It is just that at one point the cosmos was the size of a marble. -- Colin Angus Mackay
-
I once saw a routine from a junior level programmer (though not to read the 14 degrees and certifications on his resume) that was a replacement for atoi() because he didn't realize it existed. What's even better is that the routine (a couple of screens long) had errors on almost every single line. Really. My only regret is not having printed it out so that I could frame it. No, looking at code like that doesn't make me sick. It makes me feel like an experienced programmer who should be charging more. :-D
Author of The Career Programmer and Unite the Tribes www.PracticalStrategyConsulting.com
Christopher Duncan wrote:
a replacement for atoi() ... a couple of screens long
While it's stupid to reinvent something, one should at the very least try to do it with elegance and finesse. An atoi like function ought to be just a few lines long...
-- Not a substitute for human interaction
-
Christopher Duncan wrote:
atoi()
How do other people pronounce that? Right or wrong, I've gotten used to saying something along the lines of "a-toy" rather than "a-to-i" over the years. I must admit I've gotten some odd looks before. :laugh:
Jeremy Falcon
a-to-ee (Zweedish ;))
-- Nominated For Three Glemmys
-
Josh Smith wrote:
or does looking at really stupid code make you feel sick to your stomach, too?
Me too. And I've been looking at some real technicolor yawners of bad code lately too. Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmerMarc Clifton wrote:
Me too. And I've been looking at some real technicolor yawners of bad code lately too.
That's a damn shame. Sorry to hear it. My biggest fear about working with crappy code is that, given enough time, perhaps my brain will accept it and make sense out of it. That's a terrifying prospect, because I would have then sunk to the level of the crappy code. :~
:josh: My WPF Blog[^]
-
a-to-ee (Zweedish ;))
-- Nominated For Three Glemmys
-
Oh, but we consultants have a special place in our hearts for employees that insist they know better, then code gems like this. I did not want to leave out the other side of the coin - when you are constantly cleaning up gems like this.... hmmm, maybe I should change my sig
Charlie Gilley Will program for food... Whoever said children were cheaper by the dozen... lied. My son's PDA is an M249 SAW. My other son commutes in an M1A2 Abrams
charlieg wrote:
My other son commutes in an M1A2 Abrams
:cool: Reminds me of something I told a coworker the other day. He was giving our admin person (Debbie) a hard time. I pulled him to the side, and whispered just loudly enough for Debbie to overhear: "You know, I'd lighten up if I were you. Her son kills people for a living." Her son is a Marine.
Software Zen:
delete this; -
Actually, if you are a consultant, then this poster will truly be meaningful: Consulting enjoy. And if you want lot's of hoots, check out all of the posters....
Charlie Gilley Will program for food... Whoever said children were cheaper by the dozen... lied. My son's PDA is an M249 SAW. My other son commutes in an M1A2 Abrams
Awesome. I haven't checked out the site in a while. :-D:-D
Software Zen:
delete this; -
Marc Clifton wrote:
Me too. And I've been looking at some real technicolor yawners of bad code lately too.
That's a damn shame. Sorry to hear it. My biggest fear about working with crappy code is that, given enough time, perhaps my brain will accept it and make sense out of it. That's a terrifying prospect, because I would have then sunk to the level of the crappy code. :~
:josh: My WPF Blog[^]
Josh Smith wrote:
That's a terrifying prospect, because I would have then sunk to the level of the crappy code.
I honestly don't think that will happen. In fact, I find the opposite--when I look at other people's code and barf, I actually turn an even more critical eye to my own code. It's actually been quite illuminating over the last 8 months or so. I find that I am documenting a LOT more, and the last few weeks, I've really been digging into UML and trying to become proficient at it. I've gone through 3 UML product evaluations in the process as well. :sigh: Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmer -
Josh Smith wrote:
That's a terrifying prospect, because I would have then sunk to the level of the crappy code.
I honestly don't think that will happen. In fact, I find the opposite--when I look at other people's code and barf, I actually turn an even more critical eye to my own code. It's actually been quite illuminating over the last 8 months or so. I find that I am documenting a LOT more, and the last few weeks, I've really been digging into UML and trying to become proficient at it. I've gone through 3 UML product evaluations in the process as well. :sigh: Marc
Some people believe what the bible says. Literally. At least [with Wikipedia] you have the chance to correct the wiki -- Jörgen Sigvardsson
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmerMarc Clifton wrote:
In fact, I find the opposite--when I look at other people's code and barf, I actually turn an even more critical eye to my own code.
Kudos to he who makes lemonade from lemons! :jig: I suppose you're right about that. Mental degradation is probably not a side effect of reading barf-inducing code. :^)
:josh: My WPF Blog[^]
-
Jim Crafton wrote:
Oooh, ooh, post the code! Post the code!
I can't. I don't want to violate my NDA! :~ General gist:
class TextReederHelper
{
int i;
int ii = 72;
public TextReederHelper()
{
//ii = -12;
//ii = -12;
ii = -12;
}public int AddValuesIntegerlly( int i, int ii )
{
if( i < ii ) return i + ii;
return i + ii; }
}Holy Bunghole, I'm gonna heave! :wtf:
:josh: My WPF Blog[^]
-
charlieg wrote:
My other son commutes in an M1A2 Abrams
:cool: Reminds me of something I told a coworker the other day. He was giving our admin person (Debbie) a hard time. I pulled him to the side, and whispered just loudly enough for Debbie to overhear: "You know, I'd lighten up if I were you. Her son kills people for a living." Her son is a Marine.
Software Zen:
delete this;lol - that's priceless... yes, it is comforting to see my 16 year old daughter explain to wannabee boy friends that her Dad is tough, but her brothers are worse :)
Charlie Gilley Will program for food... Whoever said children were cheaper by the dozen... lied. My son's PDA is an M249 SAW. My other son commutes in an M1A2 Abrams