What is Better Code in Your Opinion?
-
What happened to if(IsLounge) { Label1.Text="No Programming Questions"; } elseif { Label1.Text="Ask in appropriate forum"; }
A room without books is like a body without a soul. - Cicero (106 BC - 43 AD)
-
This:
//If the flag is on then if(READBIT(\*pGlobalFlags, uFlag)) { //Value is set to on bstrValue = "ON"; } else { //Value is set to off bstrValue = "OFF"; }Or this:
bstrValue = READBIT(*pGlobalFlags, uFlag) ? "ON" : "OFF";
:confused:
Matt Gerrans
They are both the same. The first one has extraneous comments though. The code clearly says it's being set to "OFF or "ON"... why say the same thing in a comment?
"Quality Software since 1983!"
http://www.smoothjazzy.com/ - see the "Programming" section for (freeware) JazzySiteMaps, a simple application to generate .Net and Google-style sitemaps! -
OK my bad. What about
bstrValue =READBIT
(
*pGlobalFlags, uFlag
)
?
"ON"
:
"OFF";:rolleyes:
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus
I've seen "production code" that looks a lot like that. X|
Matt Gerrans
-
Rules: The Lounge is rated PG. If you're about to post something you wouldn't want your kid sister to read then don't post it. Do not post programming questions (use the programming forums for that) and please don't post ads. So sorry, you get it, no.
A room without books is like a body without a soul. - Cicero (106 BC - 43 AD)
I'm not sure I understand your broken sentence rightly, but it sounds like you don't understand the difference between "a programming question" and "a question about programming practice." A programming question would be something like "how do you code the travelling salesman algorithm in Plain English?" * * and the answer would be a lot of dodging about without actually answering the question! :)
Matt Gerrans
-
This:
//If the flag is on then if(READBIT(\*pGlobalFlags, uFlag)) { //Value is set to on bstrValue = "ON"; } else { //Value is set to off bstrValue = "OFF"; }Or this:
bstrValue = READBIT(*pGlobalFlags, uFlag) ? "ON" : "OFF";
:confused:
Matt Gerrans
For a simple condition like that the later. The only bad part of the first approach are the comments, though I would type the second if I was doing it myself, I wouldn't really care when reading it. I hope that is a CComBSTR or some wrapper like that, or the style isn't going to make much difference.
The pig go. Go is to the fountain. The pig put foot. Grunt. Foot in what? ketchup. The dove fly. Fly is in sky. The dove drop something. The something on the pig. The pig disgusting. The pig rattle. Rattle with dove. The dove angry. The pig leave. The dove produce. Produce is chicken wing. With wing bark. No Quack. - Thedailywtf.com
-
I started to think about, but I have noticed what is a programming question in the Lounge, then my opinion goes to soapbox... Ok, ok I'm lazy about select another forum... Here goes: The first option is better. Why? The code is easy to maintain. If I wish add some task if is true (by example), I can do this:
//If the flag is on then
if(READBIT(*pGlobalFlags, uFlag))
{
//Value is set to on
bstrValue = "ON";
// another task here
MyAnotherTaskFunction();
}
else
{
//Value is set to off
bstrValue = "OFF";
}Notice what I just added 1 line of code, and in your another style I will need create the supressed if construct. Just my 2 cents Regards
For God so loved the world, that he gave his only begotten Son, that whosoever believeth in him should not perish, but have everlasting life.(John 3:16) :badger:
Well I think that's a valid point, and sort of why I also always put in the {} even around a single statement (and I think they should be required, and the IDE should insert them automatically, with the else as well). The opposite of this situation would when there are multiple statements and then all but one are removed, would you then remove the {}? Would you rearrange it to the ternary operator? However, I really only use the ternary operator when dealing with parameters (and returns):
System.Console.WriteLine ( "I want {0} piece{1} of candy." , x , x==1?"":"s" ) ; return ( x==-1?0:x ) ;The main problem with the ternary operator is that (like macroes) some times things can get confused, I don't have an example in front of me, but at times you need to use "extra" parentheses:(int)x==1?y:z // will likely cause trouble; what does the cast apply to? ((int)x==1)?y:z // do you mean this? (int)(x==1?y:z) // or this? -
Matt Gerrans wrote:
some people can't tell the difference between a question and a metaquestion.
Ha! metaquestion is very good! Do you accept metareplies too? :laugh::laugh::laugh:
For God so loved the world, that he gave his only begotten Son, that whosoever believeth in him should not perish, but have everlasting life.(John 3:16) :badger:
Hmmm, I may have this backward.... Dicky Smothers: "I asked a rhetorical question." Tommy Smothers: "I gave a rhetorical answer."
-
This:
//If the flag is on then if(READBIT(\*pGlobalFlags, uFlag)) { //Value is set to on bstrValue = "ON"; } else { //Value is set to off bstrValue = "OFF"; }Or this:
bstrValue = READBIT(*pGlobalFlags, uFlag) ? "ON" : "OFF";
:confused:
Matt Gerrans
I'd go for the if..else construct any time I can. I can't stand the ternary operator. Irrational I suppose, but there it is.
BW
If you're not part of the solution, you're part of the precipitate.
-- Steven Wright -
I'm not sure I understand your broken sentence rightly, but it sounds like you don't understand the difference between "a programming question" and "a question about programming practice." A programming question would be something like "how do you code the travelling salesman algorithm in Plain English?" * * and the answer would be a lot of dodging about without actually answering the question! :)
Matt Gerrans
Matt Gerrans wrote:
A programming question would be something like "how do you code the travelling salesman algorithm in Plain English?" *
You have to give Jerry credit though, it is a fine line being walked. And, for reasons of people searching for this stuff (let's assume the CP site search works :rolleyes:) it would be better off belonging in the VC++ forum. Personally, I'm indifferent on this one, but I do see where he's coming from.
Jeremy Falcon A multithreaded, OpenGL-enabled application.[^]
-
What happened to if(IsLounge) { Label1.Text="No Programming Questions"; } elseif { Label1.Text="Ask in appropriate forum"; }
A room without books is like a body without a soul. - Cicero (106 BC - 43 AD)
My thoughts: I find it totally appropriate that we can talk about programming in a casual way in the lounge. After all, that's what on our minds. I just don't want to see the lounge flooded with "help with my homework" requests, and "I know the VC++ forum, but I hope to get a quicker and more detailed answer here". If, to enforce this, we have to ban all programming talk from the lounge, I can live with this. But I rather have people show good manners and good taste, and don't crash into a doctors apres-ski party to ask about their furuncles. Above question is fine with me (as are the XDay programming quizzes)
Developers, Developers, Developers, Developers, Developers, Developers, Velopers, Develprs, Developers!
We are a big screwed up dysfunctional psychotic happy family - some more screwed up, others more happy, but everybody's psychotic joint venture definition of CP
Linkify!|Fold With Us! -
My thoughts: I find it totally appropriate that we can talk about programming in a casual way in the lounge. After all, that's what on our minds. I just don't want to see the lounge flooded with "help with my homework" requests, and "I know the VC++ forum, but I hope to get a quicker and more detailed answer here". If, to enforce this, we have to ban all programming talk from the lounge, I can live with this. But I rather have people show good manners and good taste, and don't crash into a doctors apres-ski party to ask about their furuncles. Above question is fine with me (as are the XDay programming quizzes)
Developers, Developers, Developers, Developers, Developers, Developers, Velopers, Develprs, Developers!
We are a big screwed up dysfunctional psychotic happy family - some more screwed up, others more happy, but everybody's psychotic joint venture definition of CP
Linkify!|Fold With Us!That's pretty much my thoughts on the matter too, just in case anyone actually cared to know that. :laugh:
Jeremy Falcon "It's a good thing to do and a tasty way to do it." - Wilford Brimley[^]
-
I'm not sure I understand your broken sentence rightly, but it sounds like you don't understand the difference between "a programming question" and "a question about programming practice." A programming question would be something like "how do you code the travelling salesman algorithm in Plain English?" * * and the answer would be a lot of dodging about without actually answering the question! :)
Matt Gerrans
-
You're all wrong. The correct answer depends on how you're getting paid - by the number of lines written(then the first), or by the functionality implemented (then the second). Yup, thats it;)
:badger:
I wonder why a company would pay you by line, because that first construct could really use some more comments if you get payed by the line ;P
WM. What about weapons of mass-construction? "You can always try to smash it with a wrench to fix that. It might actually work" - WillemM
-
Jerry Hammond wrote:
elseif
Should this not be "else"?
Brad Australian By contacting your lawyer you negate the right to sue me.
yes, see title of my reply to him. :)
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus
-
If I really wanted to do it right, I'd do something like:
bstrValue = GetBitStateAsStateString(READBIT(*pGlobalFlags, uFlag));
or, if you want to go for debuggable/more readable:
byte bit=READBIT(*pGlobalFlags, uFlag);
bstrValue = GetBitStateAsStateString(bit);This gives you at least a fighting chance to handle internationalization and centralizes the meaning of a bit when converted to a string. After all, "True" and "False" might be equally valid, so you might have:
bstrValue = GetBitStateAsTruthString(READBIT(*pGlobalFlags, uFlag));
And no, I don't write code like that usually myself! :) Marc
People are just notoriously impossible. --DavidCrow
There's NO excuse for not commenting your code. -- John Simmons / outlaw programmer
People who say that they will refactor their code later to make it "good" don't understand refactoring, nor the art and craft of programming. -- Josh SmithI was going to say neither but I didn't feel like typing why :D So if those are your only two options then #2 (no pun intended) but I also agree with Marc on the other points.
Todd Smith
-
Personally, I would do it like this, kinda taking best of both options (IMO).
// getting string value from flag
strValue = (READBIT(*pGlobalFlags, uFlag))?"ON":"OFF";// do different stuff depending on value of strValue
if(strValue == "ON")
{
MyTaskFunction();
}
else
{
MyAnotherTaskFunction();
}
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus
What if you need to change the representation for "ON" and "OFF"?
Todd Smith
-
What if you need to change the representation for "ON" and "OFF"?
Todd Smith
How does it relate to original poster's question, which I believe was about
if...elseconstruct vs ternary operator? Oh well at least I now know why my style got voted down. :doh:
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus
-
:P It's style question. People usually get away with it. IMO its equal to "Do you like code red or pitr-cola more?" kind of question.
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus
dnh wrote:
Do you like code red or pitr-cola more
Code red! ;P though I think I miss Jolt Cola the most. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb)
-
That's pretty much my thoughts on the matter too, just in case anyone actually cared to know that. :laugh:
Jeremy Falcon "It's a good thing to do and a tasty way to do it." - Wilford Brimley[^]
How about a reward system? Once you've submitted X articles of Y quality you can post anything, anywhere you want :D
Todd Smith
-
dnh wrote:
Do you like code red or pitr-cola more
Code red! ;P though I think I miss Jolt Cola the most. :)
_________________________ Asu no koto o ieba, tenjo de nezumi ga warau. Talk about things of tomorrow and the mice in the ceiling laugh. (Japanese Proverb)
http://ars.userfriendly.org/cartoons/?id=20020520[^] :)
"Throughout human history, we have been dependent on machines to survive. Fate, it seems, is not without a sense of irony. " - Morpheus