Bug in .Net 2.0's ArrayList.Clone?
-
Hi guys, I've just encountered a strange bug (I think?) in ArrayList.Clone() Here's my code :
public ShipChromosome(ArrayList deckLength, ArrayList shipList, ArrayList allShipList)
{
deckList = deckLength;
shipsInDeck = (ArrayList)shipList.Clone();
allShips = (ArrayList)allShipList.Clone();//The culprit
}#region IChromosome Members
public IChromosome Clone()
{
return new ShipChromosome(deckList, shipsInDeck, allShips);
}Okay, Here's the exception :
System.ArgumentException was unhandled - Destination array was not long enough. Check destIndex and length, and the array's lower bounds.
Some detail about parameters:
deckList=ArrayListcontaining manyint(s)shipsInDeck=ArrayListcontaining (deckList.Count)ArrayList(s) which hold manyShipObjectallShips=ArrayListcontaining allShipObject(s) inShipsInDeck(Hey, I'm lazy!! :rolleyes: ) Any idea guys?Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
We need more information and context. What are the counts/lengths of those collections? Does it go wrong the very first time, or just after a lot of similar operations? Are some of those collections growing all the time? What is this app about? :)
Luc Pattyn [My Articles] Nil Volentibus Arduum iSad
-
We need more information and context. What are the counts/lengths of those collections? Does it go wrong the very first time, or just after a lot of similar operations? Are some of those collections growing all the time? What is this app about? :)
Luc Pattyn [My Articles] Nil Volentibus Arduum iSad
Luc Pattyn wrote:
What are the counts/lengths of those collections?
The first and second ArrayList always have 4 Items (setting) The third is changing every time.
Luc Pattyn wrote:
Does it go wrong the very first time, or just after a lot of similar operations?
After a lot of similar operations.
Luc Pattyn wrote:
Are some of those collections growing all the time?
Answered.
Luc Pattyn wrote:
What is this app about?
Ship park scheduling(?), There's many decks(4) and many ships (hundred) and it must select the best combination for the ship (Every ship has different length and park cost)
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
-
Luc Pattyn wrote:
What are the counts/lengths of those collections?
The first and second ArrayList always have 4 Items (setting) The third is changing every time.
Luc Pattyn wrote:
Does it go wrong the very first time, or just after a lot of similar operations?
After a lot of similar operations.
Luc Pattyn wrote:
Are some of those collections growing all the time?
Answered.
Luc Pattyn wrote:
What is this app about?
Ship park scheduling(?), There's many decks(4) and many ships (hundred) and it must select the best combination for the ship (Every ship has different length and park cost)
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
Firo Atrum Ventus wrote:
Ship park scheduling
Amazing, I looked at something like this in the 90s, it required mapping the docks and defining segments, each ship would take up #n segments based on length, each 3rd (or random) segment had a services outlet and we had to get as many service outlets in use as possible. I'm astonished this has not already been done :) we could not get funding for the project at the time.
Never underestimate the power of human stupidity RAH
-
Luc Pattyn wrote:
What are the counts/lengths of those collections?
The first and second ArrayList always have 4 Items (setting) The third is changing every time.
Luc Pattyn wrote:
Does it go wrong the very first time, or just after a lot of similar operations?
After a lot of similar operations.
Luc Pattyn wrote:
Are some of those collections growing all the time?
Answered.
Luc Pattyn wrote:
What is this app about?
Ship park scheduling(?), There's many decks(4) and many ships (hundred) and it must select the best combination for the ship (Every ship has different length and park cost)
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
Half answered. How many elements are in the third collection, the one that grows; initially, halfway, and when it fails? and how often are you doing all this cloning? and what happens to all those clones, are you storing them in yet another collection? insufficient information, best guess: LOH fragmentation. Never seen that exact error message though. :|
Luc Pattyn [My Articles] Nil Volentibus Arduum iSad
-
Half answered. How many elements are in the third collection, the one that grows; initially, halfway, and when it fails? and how often are you doing all this cloning? and what happens to all those clones, are you storing them in yet another collection? insufficient information, best guess: LOH fragmentation. Never seen that exact error message though. :|
Luc Pattyn [My Articles] Nil Volentibus Arduum iSad
Luc Pattyn wrote:
How many elements are in the third collection, the one that grows; initially, halfway, and when it fails?
Let me rephrase my previous remark, The length is not growing, it depends on the value of ShipInDecks (I use this ArrayList just to make sure the new ship hasn't been added into ShipInDeck).
Luc Pattyn wrote:
and how often are you doing all this cloning?
Cloning happens in crossover process (yes, this is Genetic Algorithm): 1. Clone 2 ShipChromosome (the class with mentioned code). //Where the error occured. 2. Do crossover from clones result.
Luc Pattyn wrote:
what happens to all those clones, are you storing them in yet another collection?
Which clones? The class?
public IChromosome Clone()create new object of ShipChromosome which should have the same value, hence the use of clone in the constructor. The array? I just cloned them from another instance of the class so that I can manage it freely.Luc Pattyn wrote:
LOH fragmentation
Looking into it. This error doesn't show up much (okay, only once), so I'm just doing this because I'm curious(ie. too many free time).
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
-
Hi guys, I've just encountered a strange bug (I think?) in ArrayList.Clone() Here's my code :
public ShipChromosome(ArrayList deckLength, ArrayList shipList, ArrayList allShipList)
{
deckList = deckLength;
shipsInDeck = (ArrayList)shipList.Clone();
allShips = (ArrayList)allShipList.Clone();//The culprit
}#region IChromosome Members
public IChromosome Clone()
{
return new ShipChromosome(deckList, shipsInDeck, allShips);
}Okay, Here's the exception :
System.ArgumentException was unhandled - Destination array was not long enough. Check destIndex and length, and the array's lower bounds.
Some detail about parameters:
deckList=ArrayListcontaining manyint(s)shipsInDeck=ArrayListcontaining (deckList.Count)ArrayList(s) which hold manyShipObjectallShips=ArrayListcontaining allShipObject(s) inShipsInDeck(Hey, I'm lazy!! :rolleyes: ) Any idea guys?Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
As an aside, you should be using List<int>, List<List<ShipObject>> and List<ShipObject> here. Generics are good and make your life better. Though I wouldn't be sure that would solve this issue. Are you updating that collection from another thread? If the size is different when it allocates the clone to when it actually does the copy, something like that might happen. I'm not sure Clone is a thread safe operation.
-
As an aside, you should be using List<int>, List<List<ShipObject>> and List<ShipObject> here. Generics are good and make your life better. Though I wouldn't be sure that would solve this issue. Are you updating that collection from another thread? If the size is different when it allocates the clone to when it actually does the copy, something like that might happen. I'm not sure Clone is a thread safe operation.
BobJanova wrote:
As an aside, you should be using List<int>, List<List<ShipObject>> and List<ShipObject> here. Generics are good and make your life better.
Sure, but I'm currently in lazy mode now. I don't want to write all that comment for those new developers.
BobJanova wrote:
Are you updating that collection from another thread? If the size is different when it allocates the clone to when it actually does the copy, something like that might happen.
Nope, this application is a prototype, everything runs in the main thread.
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
-
BobJanova wrote:
As an aside, you should be using List<int>, List<List<ShipObject>> and List<ShipObject> here. Generics are good and make your life better.
Sure, but I'm currently in lazy mode now. I don't want to write all that comment for those new developers.
BobJanova wrote:
Are you updating that collection from another thread? If the size is different when it allocates the clone to when it actually does the copy, something like that might happen.
Nope, this application is a prototype, everything runs in the main thread.
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
The generic type declaration is the comment, it is much clearer that you must put ints in there than if it's declared ArrayList and you can put anything in, but something will crash if you put the wrong type in. Honestly, in .Net 2 and up, you should only use the non-generic collections if you actually don't know what type you want to put in there.
-
The generic type declaration is the comment, it is much clearer that you must put ints in there than if it's declared ArrayList and you can put anything in, but something will crash if you put the wrong type in. Honestly, in .Net 2 and up, you should only use the non-generic collections if you actually don't know what type you want to put in there.
No, no, no, you don't understand. If I use a generics, I would have to put a mini documentation about generics (No, I'm not joking. I've been asked about the meaning of generics in my code TWICE. :doh: )
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D
-
No, no, no, you don't understand. If I use a generics, I would have to put a mini documentation about generics (No, I'm not joking. I've been asked about the meaning of generics in my code TWICE. :doh: )
Oxfords English < Official CCC Players Dictionary Excuse me for my improper grammar and typos. It's because English is my primary language, not my first language. My first languages are C# and Java. VB, ASP, JS, PHP and SQL are my second language. Indonesian came as my third language. My fourth language? I'm still creating it, I'll let you know when it's done! :-D