Trying to design thread safe class
-
I will reiterate: When your init() method is called, inside your init() function, you know if you're already initialized (thus, deinit() first, then re-init). Best, John
-- LogWizard - Log Viewing can be a joy!
-
I will reiterate: When your init() method is called, inside your init() function, you know if you're already initialized (thus, deinit() first, then re-init). Best, John
-- LogWizard - Log Viewing can be a joy!
-
deinit has to be public otherwise if someone calls init twice it will reinitialize automatically on second call - if I follow that approach you mention, is it thread safe?
why?
-- LogWizard - Log Viewing can be a joy!
-
why?
-- LogWizard - Log Viewing can be a joy!
-
why?
-- LogWizard - Log Viewing can be a joy!
-
because that is how the class was used before that in C++ I am rewriting now Ok if I follow your suggestion then calling init twice - will reinitialize it yes? But is it thread safe now?
You really need to get a grasp on threading concepts. 1. Since you're accessing data inside a lock(), it is thread-safe 2. You can force the clients of your class to call init before using it - either with Debug.Asserts, or by throwing an exception if the class is not initalized 3. Why would you want to re-init this several times? Best, John
-- LogWizard - Log Viewing can be a joy!
-
You really need to get a grasp on threading concepts. 1. Since you're accessing data inside a lock(), it is thread-safe 2. You can force the clients of your class to call init before using it - either with Debug.Asserts, or by throwing an exception if the class is not initalized 3. Why would you want to re-init this several times? Best, John
-- LogWizard - Log Viewing can be a joy!
Few points: 1) I will make that class actually internal and only other class in DLL will be able to use it (I am writing that DLL too) - users can now use other public classes of DLL which use my Parameters class 2) So the only direct user of that class is ME and I can ensure before its properties are accessed by other methods in other classes, there is a call checking if the method is inited or not 3) Maybe users want to specify other parameters - hence need for deinit What do you think now?
-
Few points: 1) I will make that class actually internal and only other class in DLL will be able to use it (I am writing that DLL too) - users can now use other public classes of DLL which use my Parameters class 2) So the only direct user of that class is ME and I can ensure before its properties are accessed by other methods in other classes, there is a call checking if the method is inited or not 3) Maybe users want to specify other parameters - hence need for deinit What do you think now?
3. you can provide a function (thread-safe) that changes the values (without de-initializing). Best, John
-- LogWizard - Log Viewing can be a joy!
-
3. you can provide a function (thread-safe) that changes the values (without de-initializing). Best, John
-- LogWizard - Log Viewing can be a joy!
-
Why are you so much against Deinit function? Is it so problematic? Assume I want Deinit function, I basically gave all the details in above comments and in the main question - would you say in such case my Parameters class is thread safe?
1. About deinit()- if that's what you want, fine. It's just that to me it seems to just bring extra complexity - but hey, it's your code :) 2. Yes, it's thread-safe Best, John
-- LogWizard - Log Viewing can be a joy!
-
1. About deinit()- if that's what you want, fine. It's just that to me it seems to just bring extra complexity - but hey, it's your code :) 2. Yes, it's thread-safe Best, John
-- LogWizard - Log Viewing can be a joy!
Is it also thread safe if I remove isInited checks from X1 and X2 getters? - Granted no one calls any methods of this class, unless a init method is called (this I can ensure because I am using this class directly) - I have isInited check first in any method calling this class.
-
Is it also thread safe if I remove isInited checks from X1 and X2 getters? - Granted no one calls any methods of this class, unless a init method is called (this I can ensure because I am using this class directly) - I have isInited check first in any method calling this class.
1. Yes it is - variables X1/X2 are automatically initialized to zero. 2. You modified your code:
public static int X1()
{
if(!isInited()) throw new Exception("init first");
return x1;}
should be
public static int X1()
{
lock(this) {
if(!isInited()) throw new Exception("init first");
return x1;
}
}Best, John
-- LogWizard - Log Viewing can be a joy!
-
1. Yes it is - variables X1/X2 are automatically initialized to zero. 2. You modified your code:
public static int X1()
{
if(!isInited()) throw new Exception("init first");
return x1;}
should be
public static int X1()
{
lock(this) {
if(!isInited()) throw new Exception("init first");
return x1;
}
}Best, John
-- LogWizard - Log Viewing can be a joy!
Yeah but I said what if I do
public static int X1()
{return x1;}
Granted none calls these methods before INIT method is called (I can ensure this because I am writing those methods) - I will check
isInitedcalls in the start of each method calling this class -
Yeah but I said what if I do
public static int X1()
{return x1;}
Granted none calls these methods before INIT method is called (I can ensure this because I am writing those methods) - I will check
isInitedcalls in the start of each method calling this classNo, that is not thread-safe. This is :
public static int X1{} { lock(locker) return x1; }
Best, John
-
No, that is not thread-safe. This is :
public static int X1{} { lock(locker) return x1; }
Best, John
-
Please look at my final version and tell me what you think: http://codepad.org/T3D6uabs[^]
yes, it's threadsafe
-- LogWizard - Log Viewing can be a joy!
-
yes, it's threadsafe
-- LogWizard - Log Viewing can be a joy!
Thanks a lot, few more questions, and I would appreciate if you can help: - if I add more variables other than x1 and x2 but I maintain same style in accessing and initializing them will it affect thread safety? will it affect performance? (probably). Do you know more performance friendly way to solve the problem my class solves?
-
Thanks a lot, few more questions, and I would appreciate if you can help: - if I add more variables other than x1 and x2 but I maintain same style in accessing and initializing them will it affect thread safety? will it affect performance? (probably). Do you know more performance friendly way to solve the problem my class solves?
1. if you add more variables in the same manner, yes 2. will it affect performance? don't worry about that, performance will be the same. And on the init()/deinit() - the "decrease" won't be noticeable. 3. Your class is fine Best, John
-- LogWizard - Log Viewing can be a joy!
-
1. if you add more variables in the same manner, yes 2. will it affect performance? don't worry about that, performance will be the same. And on the init()/deinit() - the "decrease" won't be noticeable. 3. Your class is fine Best, John
-- LogWizard - Log Viewing can be a joy!
-
1. if you add more variables in the same manner, yes 2. will it affect performance? don't worry about that, performance will be the same. And on the init()/deinit() - the "decrease" won't be noticeable. 3. Your class is fine Best, John
-- LogWizard - Log Viewing can be a joy!
Great job supporting this OP, John. I am voting your replies up. cheers, Bill
«I want to stay as close to the edge as I can without going over. Out on the edge you see all kinds of things you can't see from the center» Kurt Vonnegut.