Trying to design thread safe class

[Lost User]

Is it also thread safe if I remove isInited checks from X1 and X2 getters? - Granted no one calls any methods of this class, unless a init method is called (this I can ensure because I am using this class directly) - I have isInited check first in any method calling this class.

[John Torjo]

1. Yes it is - variables X1/X2 are automatically initialized to zero. 2. You modified your code:

public static int X1()
{
if(!isInited()) throw new Exception("init first");
return x1;

}

should be

public static int X1()
{
lock(this) {
if(!isInited()) throw new Exception("init first");
return x1;
}
}

Best, John

-- LogWizard - Log Viewing can be a joy!

[Lost User]

Yeah but I said what if I do

public static int X1()
{

  return x1;

}

Granted none calls these methods before INIT method is called (I can ensure this because I am writing those methods) - I will check isInited calls in the start of each method calling this class

[John Torjo]

No, that is not thread-safe. This is :

public static int X1{} { lock(locker) return x1; }

Best, John

-- Romania is in mourning

[Lost User]

Please look at my final version and tell me what you think: http://codepad.org/T3D6uabs[^]

[John Torjo]

yes, it's threadsafe

-- LogWizard - Log Viewing can be a joy!

[Lost User]

Thanks a lot, few more questions, and I would appreciate if you can help: - if I add more variables other than x1 and x2 but I maintain same style in accessing and initializing them will it affect thread safety? will it affect performance? (probably). Do you know more performance friendly way to solve the problem my class solves?

[John Torjo]

1. if you add more variables in the same manner, yes 2. will it affect performance? don't worry about that, performance will be the same. And on the init()/deinit() - the "decrease" won't be noticeable. 3. Your class is fine Best, John

-- LogWizard - Log Viewing can be a joy!

[Lost User]

Thanks a lot!!! So you are saying if I add more properties in same manner, it won't be problem?

[BillWoodruff]

Great job supporting this OP, John. I am voting your replies up. cheers, Bill

«I want to stay as close to the edge as I can without going over. Out on the edge you see all kinds of things you can't see from the center» Kurt Vonnegut.

[John Torjo]

Thanks :-O

-- LogWizard - Log Viewing can be a joy!

[John Torjo]

Yup, that's exactly what I'm saying :) Best, John

-- LogWizard - Log Viewing can be a joy!

[Lost User]

Thanks for help

[Lost User]

I am voting your replies up. me too

[John Torjo]

you're welcome Best, John

-- LogWizard - Log Viewing can be a joy!