Why you shouldn't inherit someone else's code...
-
My bet is that the SMTP method runs asynchronously and they wanted to make sure it goes through before the code goes on. Could be worse, I've inherited a code base that crashes when compiled in release build, works only in debug build. Thankfully, I am rid of it now.
Then he should put that send mail call in an async method and prevent user from sending another mail or closing the program before it's done.
-
Then he should put that send mail call in an async method and prevent user from sending another mail or closing the program before it's done.
I suppose that's kinda the point of the loop in the first place: To prevent the user from doing anything else in the meantime.
-
I just spent over an hour fixing some custom DateTime TextBox that only worked if the system clock was in a specific Dutch format (both CurrentCulture and CurrentUICulture had to match) X| I'm sure it all works at the customer (for now), but as a developer I prefer having my OS in English because it's more Googleable. And I REALLY don't know what to make of this :~
smtp.Send(mail)
For n = 1 To 10
Thread.Sleep(500)
Application.DoEvents()
NextI wanted to apply the boy scout rule, but that's a full time job X| There's new work (and a new customer) in it for me though. Probably a new web or mobile application hosted in Azure :D
Best, Sander sanderrossel.com Continuous Integration, Delivery, and Deployment arrgh.js - Bringing LINQ to JavaScript Object-Oriented Programming in C# Succinctly
Sander Rossel wrote:
I just spent over an hour fixing some custom DateTime TextBox that only worked if the system clock was in a specific Dutch format (both CurrentCulture and CurrentUICulture had to match)
Yet another reason why we UI developers get the big money :rolleyes:.
Sander Rossel wrote:
I prefer having my OS in English because it's more Googleable
My employer insists on providing our UI's in English, French, Italian, German, Spanish, Japanese, Chinese Simplified, and occasionally Polish and Russian. Despite that, we find most of our customers running the UI in English. I think you've helped me figure out why.
Software Zen:
delete this; -
Quote:
And I REALLY don't know what to make of this
Simple: it's a chunk of code which says "I have absolutely no idea what the :elephant: I'm doing".
"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony AntiTwitter: @DalekDave is now a follower!
Did somebody also comment out code, then leave it to be checked into the repository? That's a sure sign too. yes, I deal with that on a daily basis. Them: "What if we ever change the repository? Then we lose all that history!" Me: "Who ******* cares? The application should support the business rules at this point in time. If those ever change, we need to understand how to make the application work differently, and write that code. Having this clutter around just makes the code less readable."
-
Then he should put that send mail call in an async method and prevent user from sending another mail or closing the program before it's done.
-
It could be worse in case of c++... I faced the situation when inherited from a class which implement a method "Sleep". For a lazy implementation while inheriting from that class I called Sleep in the assumption I'm calling the W32 Sleep. But instead of, it ended in something like this:
for (i = 0; i < 5; i++)
{
ProcessMessages();
::Sleep(0.2 * cnMilliseconds);
ProcessMessages();
}I could kill that beast X|
It does not solve my Problem, but it answers my question
I've come across C++ code where you would see several sleeps in a row just to "resolve" a timing issue.
sleep(0);
sleep(0);
sleep(0);
sleep(0);
sleep(0);Of course after the code was properly debugged I was able to eliminate all of the sleep(0) lines.
Kelly Herald Software Developer
-
Did somebody also comment out code, then leave it to be checked into the repository? That's a sure sign too. yes, I deal with that on a daily basis. Them: "What if we ever change the repository? Then we lose all that history!" Me: "Who ******* cares? The application should support the business rules at this point in time. If those ever change, we need to understand how to make the application work differently, and write that code. Having this clutter around just makes the code less readable."
happy to hear it's not just me. I'm okay with commenting out code and forgetting about it - we all do it from time to time. HOWEVER, having multiple levels of commented out code so that you can see the history (yet we're using svn...), yeah, that's either stupid or a bad habit.
Charlie Gilley <italic>Stuck in a dysfunctional matrix from which I must escape... "Where liberty dwells, there is my country." B. Franklin, 1783 “They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759
-
A brilliant idea, although the reaction was unsurprising. Having to suffer through this three times was cruel, but applying it to a two-stage project would be fair. If told up front that it would rankle them, it would probably temper the reaction.
I agree - brilliant. I can tell you this - there may have been much disgust during the class, but a few years into working, and they are going to have their "aha!" moment.
Charlie Gilley <italic>Stuck in a dysfunctional matrix from which I must escape... "Where liberty dwells, there is my country." B. Franklin, 1783 “They who can give up essential liberty to obtain a little temporary safety deserve neither liberty nor safety.” BF, 1759
-
I suppose that's kinda the point of the loop in the first place: To prevent the user from doing anything else in the meantime.
Yes but user should be still allowed to do stuffs such as clicking on menus or continue typing. Using async method gives user smooth experience. While using thread.sleep and window.doevents continuously wont be smooth, I believe.
-
Yes but user should be still allowed to do stuffs such as clicking on menus or continue typing. Using async method gives user smooth experience. While using thread.sleep and window.doevents continuously wont be smooth, I believe.
For starters, I don't mean to defend the code. It's a clear code smell and should be restructured to be asynchronous proper. That said, it can be smooth depending on the interaction rate. No process in computing ever is smooth in reality, it's just granular on a fine-enough scale to make us, slow-reacting meatbags, think, it's smooth. In gaming, 60 FPS are, as a rule of thumb, pretty enough to make things feel smooth so if the application processes messages 60 times per second, that would feel smooth despite doing busy-wait-nonsense.
