I've posted this question[^] May you please take a look and provide inputs? Thx a

This would fail if obj is double... :-\

Well in theory not... but our middleware doesn't support uint and float so for us (practically) they are bad.

Yes!! Actually the question was raised by the same colleague when I told him its wrong.... :-D

I was assigned a QA bug today and I found this horror code written by my colleague :mad:...

private static double ConvertToDouble(object obj, out bool good)
{
if (obj is double || obj is int)
{
good = true;
return (double)obj;
}

        good = false;
        return double.NaN;
    }

This code exploded in to

Exception type: InvalidCastException
Message: Specified cast is not valid.
[System.InvalidCastException]

My eyes were paining, as I coded per requirements, I shouted for it was crowded, and he gifted me diamonds, please read full poem at http://bansalankush.blogspot.in/2011/09/morning-dream.html[^]

I missed to recognize that.... have my vote of 5 for "eye for detail" lol :)

What if I tell you he is an experienced C# developer:cool:

Someone told me that String.Copy is faster than raw assignment... So

_field = string.Copy(s.Field);

might actually perform better than

_field = s.Field

Is he crazy or am I mad to not have known this?? :~ :doh:

some might actually do. I know a person who says worlds ending soon, so lets not design!! :wtf:

Yeah... original dev didn't took chances, but fore sure I have to. I'll kick on his a** next time i see him.

public class Field
{

private readonly string _field;
private readonly string _table;

Field()
{}

public Field(Field s)
{
_table = string.Copy(s.Table);
_field = string.Copy(s.Field);
}

}

string.Copy for what?:mad:

array = new T[1];
array[array.Length - 1] = handler;

is

array[0]

not allowed in c#?

"virtual bool" so anyone can override to make it float. :-D :thumbsup:

Now I am starting to believe that world is moving to .net, :thumbsup: God save JAVA :laugh:

My vote of 5, to accept your mistake. Newton's unspecified law: No code in world is bug free!

Just saw this legacy gem

if(myArrayList.Contains(something)==true || myArrayList.Count>0)
{
if(myArrayList.Contains(something)==false)
{
default=something;
}
else
{
default=myArrayList[0];
}
}

this is for C#.net.

Wow!!!

obj.GetType().GetProperty(_propertyInfo.Name)

LOL :-D But it might be useful, if you want to set a value on a different type that has a property with same name!! otherwise :mad:

yes indeed :laugh::rose:

Rahul Rajat Singh wrote:

"it might break something" (WT Elephant?)

Yes it might break original coder's heart :laugh: I once saw this in production code: :laugh:

bool func(bool check)
{
if(check)
{
if(check)
{
//Double check to be 100% sure
}
}
}