I dont feel like going back to work...

leppie

as my 'team leader' does not why the following wrong:

a.SomeProp = a.SomeProp; // no funny side-effects, plain old property

And then he asked me not to criticize him... :wtf:

xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))

Gary Kirkham

What's wrong with it? Useless isn't the same as wrong.

Gary Kirkham Forever Forgiven and Alive in the Spirit The men said to them, "Why do you seek the living One among the dead? He is not here, but He has risen." Me blog, You read

1 21 Gigawatts

Time to go crazy upside his ass Leppie blood. Giv' dat ho a biatch slapping boyie.... oh, sorry, had some rap music on in da the background. Ahem. Politely remind him that he's a tw*t.

"...great scott!" Dilbert: Aren't all meetings like this... Richard Dawkins: "What if you're wrong?"

Ian Shlasko

But where's the line between useless and wrong? I mean, you start here:

a.SomeProp = a.SomeProp;

Then here...

Debug.Assert(a.SomeProp == a.SomeProp);

And somehow you end up here...

while (true)
{
if ((a.SomeProp == a.SomeProp) == true)
{
a.SomeProp = a.SomeProp;
break;
}
}
return (a.SomeProp == a.SomeProp);

And then it starts to get a little weird.

Proud to have finally moved to the A-Ark. Which one are you in? Developer, Author (Guardians of Xen)

BonshatS

The good old reflexive property. Maybe he just wanted to be sure it was initialized.

Nagy Vilmos

1.21 Gigawatts wrote:

Politely remind him that he's a tw*t.

How's that going to work? The correct approach is: "Oy! Gonad chops! Stop #slap# being #slap# such #slap# a #slap# tw*tting #slap# tw*t #slap# !!" ...and breath.

Panic, Chaos, Destruction. My work here is done.

Dave Parker

lol maybe the compiler optimizes that away tho? still pointless, but amusing at the same time. Was it auto-generated?

1 21 Gigawatts

Nagy Vilmos wrote:

The correct approach is:

Aahhh, I see you've dished out a few 'get real' beatings seminars before I must learn...

"...great scott!" Dilbert: Aren't all meetings like this... Richard Dawkins: "What if you're wrong?"

leppie

Ian Shlasko wrote:

And then it starts to get a little weird.

Classic :) You should see the number of side-effects this guy does. It's insane!

xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))

leppie

BonshatS wrote:

Maybe he just wanted to be sure it was initialized.

This is him exactly! http://www.geekherocomic.com/2009/07/27/common-pitfalls-initialize-your-variables/[^]

xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))

martin_hughes

What I don't get is, given your technical excellence and all that jazz, why you aren't the team leader? Mumbler? Strange body odour? Shy? Unwilling/unable to shout at management types and make demands?

print "http://www.codeproject.com".toURL().text Ain't that Groovy?

Pierre Leclercq

:-D

You can't turn lead into gold, unless you've built yourself a nuclear plant.

Pierre Leclercq

hehe... http://en.wikipedia.org/wiki/Peter_principle[^] arf: http://en.wikipedia.org/wiki/Dilbert_Principle[^]

You can't turn lead into gold, unless you've built yourself a nuclear plant.

Rama Krishna Vavilala

Early in my career, I once made a mistake of commenting a line of code, that broke the whole application. Here is how it looked like:-

void BalanceInvoice(int x, int y , int z)
{
MyInvoiceObject* p = new MyInvoiceObject(x, y, z);
delete p;

... Do other stuff that ran 200 lines ...
}

I commented the first line thinking it was useless. Turns out that the constructor and only the constructor did the main work. I hope your team leader does not write like that.

public object SomeProp
{
get
{
return 0;
}
set
{
... Connect to database ...
... Call a web service ...
... Do all the other important stuff required in the application ...
}
}

1 21 Gigawatts

martin_hughes wrote:

why you aren't the team leader

Probably because of his technical excellence.

"...great scott!" Dilbert: Aren't all meetings like this... Richard Dawkins: "What if you're wrong?"

leppie

Because he was the clown that wrote up a quarter-assed client functional requirement spec. It lacks about 70% of the requirements. And somewhere inside his skull that info still lives (or rots). Please note, this 'client spec' is the only thing our team has to go on, and consistently the client complains about missing functionality. Professionally, I have been trying to avoid taking responsibility for someone else's fuckups, but it seems there is no other way now. Bottom line is, I dont wanna do anything, while he has write-access to the code. he has been spending the last 6 weeks working on something that should have taken 3 days max, given most of the code was copied from somewhere else on the internet (like pretty much all of his code, copies of other people's code, and mine...).

xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))

leppie

Side-effects are evil. Learn to appreciate that, and code becomes dead simple. I can code fresh code faster than trying to understand what his code is attempting to do.

xacc.ide
IronScheme - 1.0 beta 4 - out now!
((λ (x) `(,x ',x)) '(λ (x) `(,x ',x)))

Rama Krishna Vavilala

leppie wrote:

Side-effects are evil.

Yes as I said I broke the main logic an entire application commenting out what I thought was useless.

Marc Clifton

leppie wrote:

Side-effects are evil. Learn to appreciate that, and code becomes dead simple.

But isn't that the worst thing about AOP, that you don't know what side effects might be introduced? Marc

Will work for food. Interacx

I'm not overthinking the problem, I just felt like I needed a small, unimportant, uninteresting rant! - Martin Hart Turner

Pierre Leclercq

But do not worry, there are cases when it is legitimate to comment out some unused/unnecessary code. But what your post shows, the worst the code is, the harder to choose what to comment out.

You can't turn lead into gold, unless you've built yourself a nuclear plant.